Update transient dependancies for camera to fix build warnings #2493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52fdb0b.
| <PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.4.1" /> | ||
| <PackageReference Include="Xamarin.AndroidX.Camera.View" Version="1.4.1" /> | ||
|
|
||
| <!-- Increase Minimum Version of Transient Dependencies For Xamarin.AndroidX.Camera.Camera2 and Xamarin.AndroidX.Camera.View --> |
Collaborator
There was a problem hiding this comment.
I don't think we need them. we can update the required packages to 1.4.1.1
Member
Author
There was a problem hiding this comment.
Updating the required packages will just mean upating the transient dependancies. It is an ongoing issue. I have a discussion open about this and I have marked it as a topic for thursday meeting. We need to keep camera and media elment up to date because of issues. ATM not all the depeendacies are lining up in the new packages from last year.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix build warning messages for android when using Camera app in any project. More about transient dependancies can be found here. #2492
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
This will fix build warnings in android about a bunch of transient dependancies. This PR is not required but highly advised that we keep on top of the changes in android from Maui team and android team. We need to keep both camera and media element updated to close to current release as there dependancies are all interdpedant with various bits from Maui team and android team.